Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(rrset): Add custom metrics generation #45

Merged
merged 1 commit into from
Oct 30, 2024
Merged

test(rrset): Add custom metrics generation #45

merged 1 commit into from
Oct 30, 2024

Conversation

antrema
Copy link
Collaborator

@antrema antrema commented Oct 30, 2024

No description provided.

@antrema antrema requested a review from mydoomfr October 30, 2024 07:18
@antrema antrema self-assigned this Oct 30, 2024
@antrema antrema force-pushed the metrics-generation branch 2 times, most recently from 79dfe9d to b7b15cd Compare October 30, 2024 13:31
@antrema antrema marked this pull request as ready for review October 30, 2024 15:36
mydoomfr
mydoomfr approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@mydoomfr mydoomfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antrema
feat(rrset): Add custom metrics
b3a3bfc 
Signed-off-by: Anthony TREUILLIER <[email protected]>
@antrema antrema force-pushed the metrics-generation branch from b7b15cd to b3a3bfc Compare October 30, 2024 16:57
@antrema antrema merged commit 8311a9b into Orange-OpenSource:main Oct 30, 2024
7 checks passed
@antrema antrema deleted the metrics-generation branch October 31, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mydoomfr mydoomfr mydoomfr approved these changes

Assignees

@antrema antrema

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antrema @mydoomfr